feat: add data-plane-instance heartbeat #4230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndr-brt
requested review from
paullatzelsperger,
bscholtes1A and
jimmarino
as code owners
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+71
to
+74
| var builder = Builder.newInstance() | ||
| .url(url) | ||
| .lastActive(lastActive) | ||
| .turnCount(turnCount) |
Check notice
Code scanning / CodeQL
Deprecated method or constructor invocation Note
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #4230 +/- ##
==========================================
+ Coverage 71.74% 75.28% +3.53%
==========================================
Files 919 1040 +121
Lines 18457 20755 +2298
Branches 1037 1155 +118
==========================================
+ Hits 13242 15625 +2383
+ Misses 4756 4619 -137
- Partials 459 511 +52 ☔ View full report in Codecov by Sentry. |
ndr-brt
force-pushed
the
4220-heartbeat-data-plane
branch
3 times, most recently
from
40e2e47
to
43a1ff3
Compare
ndr-brt
force-pushed
the
4220-heartbeat-data-plane
branch
from
43a1ff3
to
3c901cc
Compare
ndr-brt
added
the
breaking-change
wolf4ood
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR changes/adds
Adds a
DataPlaneSelectorManagerthat takes care of checking the dataplanes availability.BREAKING CHANGE: there's a new
lease_idcolumn added to theedc_data_plane_instancetable, please check the diff for details.Why it does that
Avoid failing transfers for unavabilable data planes.
Further notes
data-plane-self-registrationstill "deletes" itself instead of "unregistering". It will fixed in a subsequent prLinked Issue(s)
Closes #4220
Please be sure to take a look at the contributing guidelines and our etiquette for pull requests.